fix(clustering/sync): notify declarative:reconfigure events for full sync #13860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chobits
requested review from
chronolaw,
dndx,
StarlightIbuki and
bungle
and removed request for
chronolaw and
dndx
github-actions
bot
added
core/clustering
cherry-pick kong-ee
chobits
force-pushed
the
fix/incr_sync_kag_5812
branch
from
0c52d03
to
68054fa
Compare
chronolaw
approved these changes
Nov 12, 2024
|
Need a test case for this. we should create a ticket to track it. |
StarlightIbuki
approved these changes
Nov 12, 2024
|
chronolaw
changed the title
|
Successfully created cherry-pick PR for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With full sync (
wipe = trueindo_sync()), if we dont notify other workers withdeclarative:reconfigure, the registered callbacks in other workers will not be called, like updatingkong.default_workerspace.Note that when an empty-configured CP and DP start with incremental sync enabled, the DP will rebuild routers, plugins, and the balancer twice. This occurs because the DP currently calls do_sync() twice during a single sync operation. With incremental sync disabled, it rebuilds these components only once.
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdIssue reference
Fix KAG-5812