Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kotlin v2 and new wizard #80

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Update to Kotlin v2 and new wizard #80

merged 3 commits into from
Jul 1, 2024

Conversation

pahill
Copy link
Contributor

@pahill pahill commented Jun 25, 2024

No description provided.

@pahill pahill requested review from zamulla, terrakok and zsmb13 June 25, 2024 09:24
Comment on lines 33 to 34
implementation(kotlin("test-common"))
implementation(kotlin("test-annotations-common"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation(kotlin("test")) is enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

}
commonTest.dependencies {
implementation(kotlin("test-common"))
implementation(kotlin("test-annotations-common"))
}
val androidUnitTest by getting {
dependencies {
implementation(kotlin("test-junit"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete implementation(kotlin("test-junit"))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

}
}
dependencies {
implementation(kotlin("script-runtime"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android Studio! I've removed it now, still seems to work without it

@pahill pahill merged commit 73eac70 into master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants