This repository has been archived by the owner on Jul 13, 2021. It is now read-only.
adding componentDidUpdate #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cy6erGn0m
reviewed
Oct 17, 2017
| @@ -185,7 +185,10 @@ class ReactComponentWrapper<K, P : RProps, S : RState>(var props: P, val updater | |||
| } | |||
|
|
|||
| @JsName("componentDidUpdate") | |||
| fun componentDidUpdate(prevProps: P, prevState: S) { | |||
| fun componentDidUpdate(prevProps: RProps, prevState: RState) { | |||
There was a problem hiding this comment.
Why had you changed generic types to exact ones?
There was a problem hiding this comment.
only way I could get it to compile. But feel free to change. My only goal was getting that event to fire and it wasn't without this change.
|
Merged manually, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15