Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scripts] Adding Windows scripts #361

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

loumalouomega
Copy link
Member

This PR introduces a set of new build scripts for Windows OS. These scripts are added to the "scripts" directory and serve various purposes. Here's a brief overview of the changes made:

  1. scripts/build.bat: This script sets up the compiler and various environment variables, then configures and builds the project using CMake. It also includes options to control the build type, enable/disable testing, and build components like C, Python, and Fortran.

  2. scripts/build_and_test.bat: This script is designed to be run from the build directory. It invokes the scripts/build.bat script with specific options and then runs CTests for testing the project. Afterward, it runs Python tests.

  3. scripts/build_c.bat: This script is used to build the C component of the project by calling the scripts/build.bat script with appropriate settings.

  4. scripts/build_cpp.bat: This script is used to build the C++ component of the project by calling the scripts/build.bat script.

  5. scripts/build_python.bat: This script is used to build the Python component of the project by calling the scripts/build.bat script.

In summary, this PR adds new build scripts to the project, making it easier to configure, build, and test different components of the project, such as C, C++, and Python, with various options and settings in the Windows operative system.

Fixes #359 and #360

@pooyan-dadvand
Copy link
Member

The missing option was the --config Release . Working with following command:

cmake -H"." -B"build" -DCO_SIM_IO_BUILD_C=ON -DCO_SIM_IO_BUILD_TESTING=ON -DCO_SIM_IO_BUILD_MPI=OFF -
cmake --build "build" --config Release --target install

Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

Also, can you please incorporate the comment of Pooyan?

scripts/build.bat Outdated Show resolved Hide resolved
scripts/build.bat Outdated Show resolved Hide resolved
scripts/build_python.bat Show resolved Hide resolved
scripts/build.bat Outdated Show resolved Hide resolved
loumalouomega and others added 3 commits October 4, 2023 09:01
Co-authored-by: Philipp Bucher <philipp.bucher@tum.de>
Co-authored-by: Philipp Bucher <philipp.bucher@tum.de>
@loumalouomega
Copy link
Member Author

some questions

Also, can you please incorporate the comment of Pooyan?

It is already added into the build.bat if you take a look

Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@philbucher
Copy link
Member

last thing, could you please update the docs to point to the new files? Thx

@loumalouomega loumalouomega merged commit 6fd6931 into master Oct 5, 2023
25 checks passed
@loumalouomega loumalouomega deleted the scripts/windows-scripts branch October 5, 2023 08:58
@loumalouomega
Copy link
Member Author

last thing, could you please update the docs to point to the new files? Thx

Okay

@loumalouomega
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build script has debug as the build type
3 participants