Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsm 72 patch 1 #132

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Dsm 72 patch 1 #132

wants to merge 8 commits into from

Conversation

dsm-72
Copy link

@dsm-72 dsm-72 commented Mar 10, 2023

Branch prediction wrapped as something reusable. Faithfully recreates example that was in branch-pred branch

@coveralls
Copy link

coveralls commented Mar 10, 2023

Pull Request Test Coverage Report for Build 4489613964

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 4165236439: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link
Collaborator

@scottgigante scottgigante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, would you look at that!!!

I'd recommend an ipynb for the tutorial rather than a .py but hey I'm just a random guy on the internet with admin privileges.

@scottgigante
Copy link
Collaborator

Looks like you gotta run black though.

@dsm-72
Copy link
Author

dsm-72 commented Mar 22, 2023

@scottgigante check tutorial. Someone else should go through and test this

@scottgigante
Copy link
Collaborator

Still failing lints. Also brach_prediction.py -> branch

@dsm-72
Copy link
Author

dsm-72 commented Mar 22, 2023

@scottgigante what do I run to deal with lints? You want me to rename the file?

@scottgigante
Copy link
Collaborator

@scottgigante what do I run to deal with lints?

Looks like you gotta run black though.

You want me to rename the file?

Yes, there's a typo in the file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants