Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config samples #1002

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: config samples #1002

merged 1 commit into from
Nov 12, 2024

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Nov 11, 2024

Description

  • Align CR names to "cr-kind-sample"
  • Fix AuthPolicy sample deploy error due to missing indentation
  • Fix DNSPolicy sample deploy error due to
    • endpoint field has been removed
    • providerRefs is required

Verification

  • Deploying the samples should not result in an error
kubectl apply -f config/samples/kuadrant_v1_authpolicy.yaml
kubectl apply -f config/samples/kuadrant_v1_dnspolicy.yaml
kubectl apply -f config/samples/kuadrant_v1_ratelimitpolicy.yaml
kubectl apply -f config/samples/kuadrant_v1_tlspolicy.yaml
kubectl apply -f config/samples/kuadrant_v1beta1_kuadrant.yaml

@KevFan KevFan self-assigned this Nov 11, 2024
@KevFan KevFan added area/doc Improvements or additions to documentation good first issue Good for newcomers size/small labels Nov 11, 2024
@KevFan KevFan force-pushed the sample branch 2 times, most recently from 3af8251 to 0b7d194 Compare November 11, 2024 16:09
@KevFan KevFan requested a review from a team November 12, 2024 07:23
@KevFan
fix: config samples
374b2dc 
Signed-off-by: KevFan <chfan@redhat.com>
didierofrivia
didierofrivia approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛑️

@KevFan KevFan merged commit 365b170 into Kuadrant:main Nov 12, 2024
26 checks passed
maleck13 pushed a commit that referenced this pull request Nov 13, 2024
@KevFan @maleck13
fix: config samples (#1002)
2c6aa0e 
Signed-off-by: KevFan <chfan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didierofrivia didierofrivia didierofrivia approved these changes

@guicassolato guicassolato guicassolato approved these changes

Assignees

@KevFan KevFan

Labels
area/doc Improvements or additions to documentation good first issue Good for newcomers size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevFan @guicassolato @didierofrivia