-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAS generation and Dev Spaces #62
Conversation
e328639
to
b997a5f
Compare
@david-martin ready for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=====================================
Coverage 0.38% 0.38%
=====================================
Files 17 17
Lines 783 783
=====================================
Hits 3 3
Misses 780 780 ☔ View full report in Codecov by Sentry. |
Related docs PR: Kuadrant/docs.kuadrant.io#84 (will have a preview) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small suggestions for ease of following,
otherwise, looks good.
Got through it ok
9b33a41
to
0ff641e
Compare
@david-martin fixed up |
Co-authored-by: David Martin <david-martin@users.noreply.github.com>
0ff641e
to
fd620bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Draft PR