Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS generation and Dev Spaces #62

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jasonmadigan
Copy link
Member

Draft PR

@jasonmadigan
Copy link
Member Author

@david-martin ready for review

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.38%. Comparing base (b710c93) to head (0ff641e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #62   +/-   ##
=====================================
  Coverage   0.38%   0.38%           
=====================================
  Files         17      17           
  Lines        783     783           
=====================================
  Hits           3       3           
  Misses       780     780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonmadigan
Copy link
Member Author

jasonmadigan commented Mar 13, 2024

Related docs PR: Kuadrant/docs.kuadrant.io#84 (will have a preview)

Copy link
Contributor

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small suggestions for ease of following,
otherwise, looks good.
Got through it ok

doc/openapi-openshift-dev-spaces.md Outdated Show resolved Hide resolved
doc/openapi-openshift-dev-spaces.md Outdated Show resolved Hide resolved
doc/openapi-openshift-dev-spaces.md Outdated Show resolved Hide resolved
doc/openapi-openshift-dev-spaces.md Outdated Show resolved Hide resolved
doc/openapi-openshift-dev-spaces.md Outdated Show resolved Hide resolved
@jasonmadigan
Copy link
Member Author

@david-martin fixed up

Co-authored-by: David Martin <david-martin@users.noreply.github.com>
Copy link
Contributor

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@david-martin david-martin merged commit 7296e1b into Kuadrant:main Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants