Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versioning in releases #88

Merged
merged 1 commit into from
Jun 25, 2024
Merged

versioning in releases #88

merged 1 commit into from
Jun 25, 2024

Conversation

eguzki
Copy link
Collaborator

@eguzki eguzki commented Jun 21, 2024 •
edited
Loading

What

Have the GitHash filled for release binaries

Verification steps

Download binary from release asset and run kuadrantctl version command. It should be something like:

wget https://github.com/Kuadrant/kuadrantctl/releases/download/v0.2.4-alpha1/kuadrantctl-v0.2.4-alpha1-linux-amd64.tar.gz

tar zxfv kuadrantctl-v0.2.4-alpha1-linux-amd64.tar.gz

./kuadrantctl version

The response being:

kuadrantctl v0.2.4-alpha1 (01007cb359e24c0f59fdf7e9f7a41aec1f00b240)

@eguzki eguzki marked this pull request as ready for review June 21, 2024 10:29
@ehearneRedHat
Copy link
Contributor

👀

@ehearneRedHat
Copy link
Contributor

Reviewed code, tested workflow file via act, and checked triggered release.

Works as expected. 🏅

Feel free to merge :)

ehearneRedHat
ehearneRedHat approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@ehearneRedHat ehearneRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good :D

@eguzki eguzki merged commit ddfe1d6 into main Jun 25, 2024
5 checks passed
@eguzki eguzki deleted the release-versioning branch June 25, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehearneRedHat ehearneRedHat ehearneRedHat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @ehearneRedHat