Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.3 #986

Merged
merged 4 commits into from
Dec 7, 2023
Merged

1.20.3 #986

merged 4 commits into from
Dec 7, 2023

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Oct 11, 2023

This is a branch to gather work on supporting features and representation changes from Minecraft 1.20.3.

Relevant changelogs:

@zml2008
Copy link
Member Author

zml2008 commented Oct 11, 2023

So, my current thought for handling version differences is, we should have a 'feature flag' system, where things like 'emit legacy hover event' or 'emit uuid as ints' vs 'emit uuid as string' are toggleable options. We'd need to produce presets for compatibility with different game versions, plus probably a 'latest' and 'most compatible' levels.

Should this be game versions? Then how do we handle snapshots?

Alternately, we could mark these revisions by:

Thoughts on what makes most sense?

@KingOfSquares
Copy link
Contributor

So, my current thought for handling version differences is, we should have a 'feature flag' system, where things like 'emit legacy hover event' or 'emit uuid as ints' vs 'emit uuid as string' are toggleable options. We'd need to produce presets for compatibility with different game versions, plus probably a 'latest' and 'most compatible' levels.

Should this be game versions? Then how do we handle snapshots?

Alternately, we could mark these revisions by:

Thoughts on what makes most sense?

I think using the protocol version is a good idea, seems like the most precise number and easiest to map to any point in releases/snapshots etc..
To my knowledge Bedrock uses the same system right(for protocol versions)? In case the bedrock serialiser or other bedrock specific stuff ever makes it in here

DrexHD added a commit to DrexHD/BlockBot that referenced this pull request Oct 31, 2023
Manually includes KyoriPowered/adventure#986
This commit should be reverted and adventure version bumped once the PR
is merged and an official version is released!
@zml2008 zml2008 added this to the 4.15.0 milestone Nov 20, 2023
@zml2008
Copy link
Member Author

zml2008 commented Dec 7, 2023

We still need to implement:

  • handling for the type field
  • NBT component serialization (or DFU integration)
  • matching the strictness of Vanilla serialization

but I think it's worth merging this as-is just to have published snapshots that others can depend on.

@zml2008 zml2008 marked this pull request as ready for review December 7, 2023 03:19
@zml2008 zml2008 self-assigned this Dec 7, 2023
@zml2008 zml2008 dismissed kashike’s stale review December 7, 2023 03:41

changes have been made

@zml2008 zml2008 enabled auto-merge December 7, 2023 03:46
@zml2008 zml2008 added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main/4 with commit 3df534c Dec 7, 2023
5 checks passed
@zml2008 zml2008 deleted the feat/mc/1.20.3 branch December 7, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants