-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.3 #986
1.20.3 #986
Conversation
So, my current thought for handling version differences is, we should have a 'feature flag' system, where things like 'emit legacy hover event' or 'emit uuid as ints' vs 'emit uuid as string' are toggleable options. We'd need to produce presets for compatibility with different game versions, plus probably a 'latest' and 'most compatible' levels. Should this be game versions? Then how do we handle snapshots? Alternately, we could mark these revisions by:
Thoughts on what makes most sense? |
text-serializer-gson/src/main/java/net/kyori/adventure/text/serializer/gson/UUIDSerializer.java
Outdated
Show resolved
Hide resolved
I think using the protocol version is a good idea, seems like the most precise number and easiest to map to any point in releases/snapshots etc.. |
Manually includes KyoriPowered/adventure#986 This commit should be reverted and adventure version bumped once the PR is merged and an official version is released!
Co-authored-by: Riley Park <rileysebastianpark@gmail.com>
e2fcd7c
to
f9a739c
Compare
We still need to implement:
but I think it's worth merging this as-is just to have published snapshots that others can depend on. |
This is a branch to gather work on supporting features and representation changes from Minecraft 1.20.3.
Relevant changelogs: