-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add OTP processing option #356
base: main
Are you sure you want to change the base?
Conversation
Add SNR plots to _report.py
add run_opt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdclarke looks like it's close! I pushed some commits to fix the CIs. CircleCI was broken and Travis wasn't running, so I fixed those. Then in terms of your changes, I had to change the order of some stuff to make the YAML match the overview.rst
.
I think what's left is:
- Update the flowchart by changing https://github.com/LABSN/mnefun/blob/main/mnefun/_flow.py
- Make it so that the SSS step uses either the raw files (if otp_dur is None) or the OTP'ed files (if otp_dur is not None)
add OTP
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage ? 20.09%
=======================================
Files ? 34
Lines ? 5185
Branches ? 0
=======================================
Hits ? 1042
Misses ? 4143
Partials ? 0 |
Closes #355