Add yyjson support to avoid rapidjson on Debian #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conduit uses rapidjson as thirdparty but its license is not compatible with Debian Free Software Guideline because of the additional clause "The Software shall be used for Good, not Evil.". More information here: https://wiki.debian.org/qa.debian.org/jsonevil
As I'm working on packaging conduit for Debian, this Pull Request suggests to use yyjson as a replacement.
I've implemented a thin wrapper to call yyjson throught the rapidjson API, in order to keep the two json backends working.
The wrapper is defined in
src/thirdparty_builtin/yyjson/conduit_yyjson.hand the CMake variableUSE_SYSTEM_YYJSONenables yyjson.All non-regression tests are passing on my machine with yyjson and rapidjson, but it likely needs additional testing with real cases.
Let me know if you agree this way to push conduit to Debian, and feel free to advise/modify/contribute!
Best,
François