None class #56
Merged
None class #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you try and finish this off @zofiakaczmarek if you have the bandwidth please? |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The None class KDE test was failing as the fixed large bandwidth was causing the underestimation of density at the center. This is now fixed and the test is running with default scipy bandwidth
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Added optional plotting with the None class UQ to plot_rel_prob_surfaces(). Some tweaks to NoneClassUQ
for more information, see https://pre-commit.ci
Added testing that initialising NoneClassUQ raises a ValueError if input is incomplete
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Added test cases of classifying posteriors in regions of high and low simulation support, including the None class
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Addressing Issue #17 : Adding UQ via an auxiliary class which is defined by the complement in parameter space of the simulation samples.
Description of the Change
Introduce new template class (additiveUQ) and child class (NoneClassUQ) which represent a broad range of UQ methods which modify the (un-normalized) classification probabilities, population model, and inference data, and modifies the output in some way to address UQ. The NoneClassUQ class is a specific kind of method, where the None class is defined as the negative space in parameter space, left behind by low simulation fidelity. With the additional class, I must add a additiveUQ object as an argument to classify, and integrate it after the original classification has taken place.
In addition to the source code, there will be accompanying tests.
Checklist
Please check all that apply to your proposed changes
Additional context