Various cleanups and improvements #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the version bumped `Cargo.lock` got updated but this was not committed.
We no longer depend on `bitcoin` and `bitcoin-units` has `serde` instead of `use-serde`.
`hex-conservative` has a faster encoding algorithm so adding it is useful. Sadly, we cannot use its parsing because of poor error reporting API. It was not made mandatory to not add the dependency needlessly. A future breaking version might remove the impls without the feature.
The MSRV documentation was not properly updated in the last version. This updates the number at several places and replaces the note that it might be decreased with a note that it will be increased (planned because of weak dependencies).
Kixunil
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bunch of issues with the hastily-released version.