Update v2 disperser protos #816
Conversation
ian-shim
force-pushed
the
update-v2-disperser-protos
branch
from
8582bdd
to
03cdacb
Compare
api/proto/common/common.proto
Outdated
| uint32 reference_block_number = 5; | ||
| repeated string relays = 4; |
There was a problem hiding this comment.
We need to decide what form the relay identifier will take. If relays are registered on chain then we can use a short identifier, e.g. a uint32 or similar. Passing the relay URLs here will be convenient but could bloat the size of the certificate.
api/proto/common/common.proto
Outdated
| bytes blob_key = 2; | ||
| BlobCommitment blob_commitment = 3; | ||
| repeated uint32 quorum_numbers = 4; | ||
| bytes blob_key = 1; |
There was a problem hiding this comment.
Is the blob key going to be equivalent to the blob hash? If "yes", perhaps if we should just call this field blob_hash.
There was a problem hiding this comment.
blob_key is used throughout the system as a hash(blob_header). What's the blob hash?
There was a problem hiding this comment.
Makes sense, I think I was mistaken about the blob hash thing.
ian-shim
force-pushed
the
update-v2-disperser-protos
branch
from
03cdacb
to
7a5abf6
Compare
| uint32 version = 1; | ||
| repeated uint32 quorum_numbers = 2; | ||
| common.BlobCommitment commitment = 3; | ||
| bytes payment_header_hash = 4; |
There was a problem hiding this comment.
Should we just include the payment header now so as to minimize api changes in the future?
|
|
||
| // BlobCertificate is what gets attested by the network | ||
| message BlobCertificate { | ||
| bytes blob_key = 1; |
There was a problem hiding this comment.
Is the blob key needed when the blob header is here?
Why are these changes needed?
Updating blob header & cert schema
Checks