[v2] Blob Metadata Store #818
Conversation
| type BlobVersion uint32 | ||
|
|
||
| type BlobKey [32]byte | ||
|
|
||
| func (b BlobKey) Hex() string { | ||
| return hex.EncodeToString(b[:]) | ||
| } | ||
|
|
||
| func HexToBlobKey(h string) (BlobKey, error) { | ||
| b, err := hex.DecodeString(h) | ||
| if err != nil { | ||
| return BlobKey{}, err | ||
| } | ||
| return BlobKey(b), nil | ||
| } | ||
|
|
||
| type BlobHeaderV2 struct { | ||
| BlobVersion BlobVersion `json:"version"` | ||
| QuorumIDs []QuorumID `json:"quorum_ids"` | ||
| BlobCommitment encoding.BlobCommitments `json:"commitments"` | ||
|
|
||
| PaymentMetadata `json:"payment_metadata"` | ||
| } |
There was a problem hiding this comment.
Placeholder for now. These will be replaced by v2 core types in #806
| return &dynamodb.CreateTableInput{ | ||
| AttributeDefinitions: []types.AttributeDefinition{ | ||
| { | ||
| AttributeName: aws.String("PK"), |
There was a problem hiding this comment.
Could you document the tables that are abbreviations? It's not obvious to me what PK and SK stand for.
|
|
||
| blobKeyPrefix = "BlobKey#" | ||
| dispersalIDPrefix = "DispersalID#" | ||
| blobMetadataSK = "BlobMetadata" |
There was a problem hiding this comment.
So we're not using immutable design where blob metadata updates create a new unique sortable item via compound SK like BlobMetadata#UUID7 or BlobMetadata#EpochSeconds?
| type BlobMetadata struct { | ||
| core.BlobHeaderV2 `json:"blob_header"` | ||
|
|
||
| BlobKey core.BlobKey `json:"blob_key"` | ||
| BlobStatus BlobStatus `json:"blob_status"` | ||
| // Expiry is Unix timestamp of the blob expiry in seconds from epoch | ||
| Expiry uint64 `json:"expiry"` | ||
| NumRetries uint `json:"num_retries"` | ||
| BlobSize uint64 `json:"blob_size"` | ||
| RequestedAt uint64 `json:"requested_at"` | ||
| } |
There was a problem hiding this comment.
Since this is a high level struct that will get reused in a bunch of places, would it be worth while to add godocs? (This request is non-blocking, feel free to disregard it if you don't think they are worthwile.)
| type BlobMetadataStore interface { | ||
| PutBlobMetadata(ctx context.Context, metadata *v2.BlobMetadata) error | ||
| GetBlobMetadata(ctx context.Context, blobKey core.BlobKey) (*v2.BlobMetadata, error) | ||
| GetBlobMetadataByStatus(ctx context.Context, status v2.BlobStatus) ([]*v2.BlobMetadata, error) | ||
| GetBlobMetadataCountByStatus(ctx context.Context, status v2.BlobStatus) (int32, error) | ||
| } |
There was a problem hiding this comment.
Please add godocs if you think it's worth it. (This request is non-blocking, feel free to disregard it if you don't think they are worthwile.)
| return &dynamodb.CreateTableInput{ | ||
| AttributeDefinitions: []types.AttributeDefinition{ | ||
| { | ||
| AttributeName: aws.String("PK"), |
There was a problem hiding this comment.
Could you document the tables that are abbreviations? It's not obvious to me what PK and SK stand for.
| type BlobMetadata struct { | ||
| core.BlobHeaderV2 `json:"blob_header"` | ||
|
|
||
| BlobKey core.BlobKey `json:"blob_key"` | ||
| BlobStatus BlobStatus `json:"blob_status"` | ||
| // Expiry is Unix timestamp of the blob expiry in seconds from epoch | ||
| Expiry uint64 `json:"expiry"` | ||
| NumRetries uint `json:"num_retries"` | ||
| BlobSize uint64 `json:"blob_size"` | ||
| RequestedAt uint64 `json:"requested_at"` | ||
| } |
There was a problem hiding this comment.
Will this eventually contain information such as blob header and/or blob cert?
Why are these changes needed?
Set up v2 blob metadata store. Only implements few basic methods for now.
Checks