Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tick issue and two mc-old features #239

Merged
merged 11 commits into from
Jun 26, 2024

Conversation

Lumine1909
Copy link
Contributor

@Lumine1909 Lumine1909 commented Jun 26, 2024

之前的tick问题:

~2_1HGZX9(RO 5408T A0VM
tick两次, diff嘻嘻

新feature:
minecraft-old allowGrindstoneOverstacking
minecraft-old MC-67

第一个可能还有未知问题 因为我没用过这个功能 我只测了诅咒附魔书
image
image

@Lumine1909 Lumine1909 changed the base branch from 2024-year to dev/1.21 June 26, 2024 11:42
@Lumine1909 Lumine1909 changed the title Two mc-old features Fix tick issue and two mc-old features Jun 26, 2024
@s-yh-china s-yh-china self-requested a review June 26, 2024 14:08
@s-yh-china
Copy link
Member

哪来的这么多commit
全是问题,我直接合到dev后改了?

Copy link
Member

@s-yh-china s-yh-china left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LeavesConfig修改应该合并到之前的patch

并且不应该是fix类别,应该是{"modify", "minecraft-old"}

commit名是不是有点太奇怪了,要不改改

@s-yh-china s-yh-china merged commit 65deeff into LeavesMC:dev/1.21 Jun 26, 2024
1 check passed
@Bluemangoo
Copy link
Member

commit名是不是有点太奇怪了,要不改改

你不是 squash merge 的吗。

@Lumine1909 Lumine1909 deleted the dev/1.21-R2 branch June 27, 2024 04:35
Lumine1909 added a commit to Lumine1909/LeavesFork that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants