-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tick issue and two mc-old features #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lumine1909
changed the title
Two mc-old features
Fix tick issue and two mc-old features
Jun 26, 2024
哪来的这么多commit |
s-yh-china
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LeavesConfig修改应该合并到之前的patch
并且不应该是fix类别,应该是{"modify", "minecraft-old"}
commit名是不是有点太奇怪了,要不改改
s-yh-china
approved these changes
Jun 26, 2024
你不是 squash merge 的吗。 |
Lumine1909
added a commit
to Lumine1909/LeavesFork
that referenced
this pull request
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前的tick问题:
tick两次, diff嘻嘻
新feature:
minecraft-old allowGrindstoneOverstacking
minecraft-old MC-67
第一个可能还有未知问题 因为我没用过这个功能 我只测了诅咒附魔书