SilentOpenChest improvements #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I have had packet adapters for GAME_STATE_CHANGE and NAMED_ENTITY_SPAWN in the past, and they kept breaking with new minecraft releases. Currently I feel like it may perhaps even make more sense to not use them to increase stability. Either way, the current way the silent open chest feature works is very wonky, and I wish someday there would be an API-only option without temporary gamemodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the SilentOpenChest feature.
These changes prevent the player from passing through the blocks when opening the chest, and prevent the chest from closing if the player moves.