Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FT232R symbol/component and FT232RL device #1

Merged
merged 10 commits into from
Oct 6, 2019

Conversation

MartijnBraam
Copy link
Contributor

@MartijnBraam MartijnBraam commented Dec 2, 2018

This adds the FT232R symbol and the FT232RL device (with the SSOP28 package that it requires)

screenshot from 2018-12-03 00-01-40

@ubruhin
Copy link
Contributor

ubruhin commented Dec 2, 2018

Thanks @MartijnBraam 😃

Here my comments after a quick review:

  • The new component category is very deep nested, I'd suggest to either move the new category one level up (as child of "Interface"), or use the "Drivers, Receivers, Transmitters" (without subcategory) instead. Or what do you think @dbrgn?
  • Symbol: Text elements for "{{NAME}}" and "{{VALUE}}" are missing. Name should be at the top left, and value at the bottom left of the symbol's outline.
  • Symbol: Generally for ICs we try to avoid placing pins at top and bottom of a symbol. We think schematics are more clean with pins only at left and right of IC symbols. Especially for GND it's often useful to place it 5.08mm below VCC because that way you can directly connect capacitors to them :)
  • Package: As it is a generic package, it would be good to move it into the base library. @dbrgn Could we generate that package with the parts generator?

@dbrgn
Copy link
Contributor

dbrgn commented Dec 2, 2018

@dbrgn Could we generate that package with the parts generator?

Yes, I can give it a try next week if I find time. We should be able to parametrize the SOIC generator for SSOP support. (I actually already started with generating TSSOP a while ago, but the branch is still sitting on my computer...)

@MartijnBraam
Copy link
Contributor Author

MartijnBraam commented Dec 2, 2018

I've updated the symbol so there's space for the caps and crystal you might need.

screenshot from 2018-12-03 01-24-37

The previous symbol was made to closely match the symbol in the FTDI datasheet.

@ubruhin
Copy link
Contributor

ubruhin commented Dec 5, 2018

Thanks for the update!

Actually the new category should be moved to the LibrePCB Base library. Could you maybe open a pull request there? The category's directory can just be moved, no need for any adjustments.

Regarding the symbol:

  • Text elements should be left-aligned to the corners of the outline (corresponding library convention is work in progress, see draft here).
  • I would move the TEST pin 2.54mm to bottom, just because there is enough space available :)

Component and device look good so far 👍

@MartijnBraam
Copy link
Contributor Author

I've fixed the text elements and the test pin and moved the category.

Its probably a good idea to use a generated SSOP28 package instead of the one I've drawn since I'm not 100% sure everything aligns correctly and the silkscreen from the generated packages are nicer.

@dbrgn
Copy link
Contributor

dbrgn commented Apr 19, 2019

Assigning this to me, so I remember to finish the SOP generator 🙂

@dbrgn dbrgn self-assigned this Apr 19, 2019
@dbrgn
Copy link
Contributor

dbrgn commented Jun 24, 2019

TSSOP work ongoing at LibrePCB-Libraries/LibrePCB_Base.lplib#33. Adding SSOP afterwards should be easy.

@dbrgn
Copy link
Contributor

dbrgn commented Jul 21, 2019

SSOP packages done: LibrePCB-Libraries/LibrePCB_Base.lplib#35

dbrgn added a commit to LibrePCB/librepcb-parts-generator that referenced this pull request Oct 1, 2019
...for compatibility with the SSOP28 package added in
LibrePCB-Libraries/FTDI.lplib#1.
dbrgn added a commit to LibrePCB/librepcb-parts-generator that referenced this pull request Oct 1, 2019
...for compatibility with the SSOP28 package added in
LibrePCB-Libraries/FTDI.lplib#1.
dbrgn added a commit to LibrePCB/librepcb-parts-generator that referenced this pull request Oct 1, 2019
...for compatibility with the SSOP28 package added in
LibrePCB-Libraries/FTDI.lplib#1.
dbrgn added a commit to LibrePCB/librepcb-parts-generator that referenced this pull request Oct 1, 2019
...for compatibility with the SSOP28 package added in
LibrePCB-Libraries/FTDI.lplib#1.
@dbrgn
Copy link
Contributor

dbrgn commented Oct 2, 2019

Hi @MartijnBraam

SSOP footprints have finally(!) been added to the base library. We have re-used your UUIDs, so if you simply delete your own package and make sure to have a dependency on the base library, everything should work as intended.

@ubruhin
Copy link
Contributor

ubruhin commented Oct 6, 2019

I removed the SSOP28 package and added the base library as dependency, so we can merge this now.

Thanks again @MartijnBraam, and sorry for taking such a long time to get this merged 😁

@ubruhin ubruhin changed the title Added FT232R symbol and FT232RL device Add FT232R symbol/component and FT232RL device Oct 6, 2019
@ubruhin ubruhin merged commit fbf7171 into LibrePCB-Libraries:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants