Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots are outdated or don't follow library conventions #27

Open
ubruhin opened this issue Dec 5, 2018 · 6 comments
Open

Screenshots are outdated or don't follow library conventions #27

ubruhin opened this issue Dec 5, 2018 · 6 comments
Labels

Comments

@ubruhin
Copy link
Member

ubruhin commented Dec 5, 2018

Most screenshots were created with LibrePCB versions much older than the official 0.1.0 release, thus some of the screenshots are outdated.

In addition, we should check if the elements visible in the screenshots do actually correspond to our library conventions (which are still work in progress). It's annoying for users to see screenshots which do not follow our library conventions.

Specific issues:

  • Component wizard shows "IC" as prefix for an OpAmp, while we actually use "U" for ICs.
  • Component wizard shows "{{PARTNUMBER}}" as default value, while it should be "{{PARTNUMBER or DEVICE}}".
@mdubinko
Copy link
Contributor

mdubinko commented Dec 8, 2018

Pardon my ignorance -- does the app itself contain any automation features that could be used to manipulate the app into a particular state, then screenshot the window -- ideally without human intervention? Perhaps something like https://blog.codeship.com/automating-screenshots-in-documentation/ (though that might be mobile-specific).

Does there exist any meta-documentation on how screenshots are being captured/managed/tracked at present? Thx.

@dbrgn
Copy link
Member

dbrgn commented Dec 8, 2018

The functional test framework (funq) that we already use for tests could be used for that. I'm not sure whether it already has a screenshotting function though. But I guess it could be done directly through Python.

@ubruhin
Copy link
Member Author

ubruhin commented Dec 8, 2018

I stored the workspace containing the example libraries and projects in the directory resources/workspace/, so at least the data to reproduce screenshots is available.

But there is no automation yet. It would be really awesome to create a Python script which automatically creates all screenshots with Funq, as suggested by @dbrgn! You can take a look at our functional tests to see how it works.

PR very welcome :)

@sixtyfive
Copy link
Contributor

sixtyfive commented Jan 26, 2020

Another thing that just had me confused for a little while trying to learn LibrePCB was that the screenshots have "required" signals and current LibrePCB has "optional" signals, which is the inverse logic.

@dbrgn
Copy link
Member

dbrgn commented Jan 26, 2020

LibreCAD

LibrePCB or LibreCAD? They're two different projects.

@sixtyfive
Copy link
Contributor

Whoops, sorry, this is going to be tripping me up for a while to come. Comment edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants