Generate output into corresponding library directory #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating the output into a directory like "out/led/pkg/", use the actual library directory where the files need to be added to, for example "out/LibrePCB_Base.lplib/pkg". This makes it much easier to copy the generated elements into the libraries. In addition, it is less error-prone since the library assignment is now stored in the generators (currently it's cumbersome to find out which files need to be copied into which library).
dbrgn
approved these changes
Aug 15, 2023
|
Thanks @dbrgn! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating the output into a directory like "out/led/pkg/", use the actual library directory where the files need to be added to, for example "out/LibrePCB_Base.lplib/pkg". This makes it much easier to copy the generated elements into the libraries.
In addition, it is less error-prone since the library assignment is now stored in the generators (until now it was cumbersome to find out which files need to be copied into which library - especially if a single script generates output for multiple libraries).
I've run all generators to verify that their new output directory is correct.