Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run LitServe with minimal dependency #138

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

After this PR, it won't be required to install PyTorch to run LitServe.

Also, adds test to make sure LitServe doesn't leak any extra requirement.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (4a3721c) to head (dcc145a).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #138   +/-   ##
===================================
- Coverage    80%    79%   -0%     
===================================
  Files        13     13           
  Lines       867    870    +3     
===================================
+ Hits        690    691    +1     
- Misses      177    179    +2     

@aniketmaurya aniketmaurya changed the title make torch optional run LitServe with minimal dependency Jun 15, 2024
@aniketmaurya aniketmaurya self-assigned this Jun 15, 2024
@aniketmaurya aniketmaurya added bug Something isn't working ci / tests labels Jun 15, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one suggestion to simplify the test

tests/minimal_run.py Show resolved Hide resolved
@aniketmaurya
Copy link
Collaborator Author

@Borda could you please help review so that we can merge?

@williamFalcon williamFalcon merged commit c89449d into main Jun 17, 2024
19 checks passed
@williamFalcon williamFalcon deleted the aniket/minimal-dep branch June 17, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants