Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject context for batching loops #139

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jun 15, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Batching loops currently lacks context injection. This PR enables that.

  • updated tests
  • updated README

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya requested a review from lantiga as a code owner June 15, 2024 19:45
@aniketmaurya aniketmaurya self-assigned this Jun 15, 2024
@aniketmaurya aniketmaurya added enhancement New feature or request and removed enhancement New feature or request labels Jun 15, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 80%. Comparing base (c89449d) to head (154a0c0).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #139   +/-   ##
===================================
  Coverage    79%    80%           
===================================
  Files        13     13           
  Lines       870    880   +10     
===================================
+ Hits        691    700    +9     
- Misses      179    180    +1     

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, each request needs to have its own context, so a list of them is the only sensible thing.
Please add to README and we can proceed!

@aniketmaurya aniketmaurya requested a review from lantiga June 17, 2024 09:22
@aniketmaurya
Copy link
Collaborator Author

hi @lantiga, I have added the README changes. could you take a look again please?

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@lantiga lantiga merged commit 12d4ee7 into main Jun 18, 2024
19 checks passed
@lantiga lantiga deleted the aniket/inject-context-batching branch June 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants