Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate error with OpenAISpec #143

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jun 18, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #141

  • Add test

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya requested a review from lantiga as a code owner June 18, 2024 11:24
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80%. Comparing base (5995b0a) to head (743c519).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #143   +/-   ##
===================================
+ Coverage    80%    80%   +1%     
===================================
  Files        13     13           
  Lines       880    890   +10     
===================================
+ Hits        700    715   +15     
+ Misses      180    175    -5     

@aniketmaurya aniketmaurya changed the title [WIP] propagate error with OpenAISpec propagate error with OpenAISpec Jun 18, 2024
@aniketmaurya aniketmaurya self-assigned this Jun 18, 2024
@aniketmaurya aniketmaurya added the bug Something isn't working label Jun 18, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice catch

tests/test_specs.py Show resolved Hide resolved
tests/test_specs.py Show resolved Hide resolved
@aniketmaurya aniketmaurya merged commit 274d57a into main Jun 20, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/propagate-spec-error branch June 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propagate Exception from inference workers to main process
2 participants