Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize batch aggregation #147

Merged
merged 4 commits into from
Jun 21, 2024
Merged

optimize batch aggregation #147

merged 4 commits into from
Jun 21, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jun 20, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Make the requests Queue timeout auto adjustable with remaining time for aggregation.

uid = request_queue.get(timeout=0.001) ----> User might choose a lower batch_timeout and this line won't respect that.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya requested a review from lantiga as a code owner June 20, 2024 11:59
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (5f7c2f0) to head (3e388d2).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #147   +/-   ##
===================================
- Coverage    79%    79%   -0%     
===================================
  Files        13     13           
  Lines       925    931    +6     
===================================
+ Hits        729    733    +4     
- Misses      196    198    +2     

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a before vs after perf comparison to the description of these optimization PRs.

@aniketmaurya
Copy link
Collaborator Author

this one doesn't bring a visible performance gain but more like better way to handle timeout. I will put perf comparisons for PRs with visible perf gains.

@aniketmaurya aniketmaurya enabled auto-merge (squash) June 21, 2024 09:35
@aniketmaurya aniketmaurya merged commit 0c91d64 into main Jun 21, 2024
18 of 19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/refacot-batch-collate branch June 21, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants