Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: OpenAISpec populate missing zip #149

Merged
merged 2 commits into from
Jun 20, 2024
Merged

bugfix: OpenAISpec populate missing zip #149

merged 2 commits into from
Jun 20, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes a bug introduced when populate_context is available for a Spec in batched streaming loop.

  • added test

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya requested a review from lantiga as a code owner June 20, 2024 14:35
@aniketmaurya aniketmaurya changed the title bugfix OpenAISpec populate missing zip bugfix: OpenAISpec populate missing zip Jun 20, 2024
@aniketmaurya aniketmaurya added the bug Something isn't working label Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (ec05a06) to head (ff248f7).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #149   +/-   ##
===================================
- Coverage    80%    79%   -2%     
===================================
  Files        13     13           
  Lines       905    925   +20     
===================================
+ Hits        727    729    +2     
- Misses      178    196   +18     

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, approved

@lantiga lantiga merged commit 5f7c2f0 into main Jun 20, 2024
19 checks passed
@lantiga lantiga deleted the bugfix/batch-stream branch June 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants