Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for continuous batching and Default loops #396

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Dec 16, 2024

What does this PR do?

Better tests = better software

Adds unit tests for Continuous batching.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya changed the title add loops tests [wip] add loops tests Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91%. Comparing base (e71f38b) to head (1820b78).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #396   +/-   ##
===================================
+ Coverage    88%    91%   +3%     
===================================
  Files        25     25           
  Lines      1775   1777    +2     
===================================
+ Hits       1560   1622   +62     
+ Misses      215    155   -60     

@aniketmaurya aniketmaurya changed the title [wip] add loops tests add loops tests Dec 16, 2024
@aniketmaurya aniketmaurya changed the title add loops tests add tests for continuous batching and Default loops Dec 16, 2024
src/litserve/loops.py Show resolved Hide resolved
src/litserve/loops.py Outdated Show resolved Hide resolved
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@aniketmaurya aniketmaurya enabled auto-merge (squash) December 16, 2024 18:13
@aniketmaurya aniketmaurya merged commit fcce973 into main Dec 16, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/test-continunous-loop branch December 16, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants