PHPCS/Composer: update PHPCompatibility #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer:
wimg/php-compatibility
has been abandoned for over a year. Usephpcompatibility/php-compatibility
instead.You were missing out on a lot of new checks, including the checks to make sure your code is compatible with the
upcomingPHP 7.4.This plugin will handle setting the PHPCS
installed_paths
automatically.This also allows for referencing the ruleset by name instead of via the path in the ruleset, which is generally more stable.
PHPCS ruleset:
phpcs.xml.dist
which will allow PHPCS to automatically pick up on it.No need to pass the
--standard=...
command-line argument anymore.According to the
composer.json
file, this code should be compatible with PHP 5.5 and above.PHPCompatibility was checking against PHP 5.5 up to PHP 7.0.
The new
testVersion
actually checks against PHP 5.5 up to the latest version (7.4 at this moment).Refs:
Suggestion:
3.10.0
3.11.0
Ref: https://github.com/djoos/Symfony-coding-standard/blob/master/UPGRADE-3.0.md
Note: the ruleset name has been changed in version 3 from
Symfony2
toSymfony
.3.5.3
3.5.6
I'd suggest removing it as it is not your dependency, but a dependency of the PHPCompatibility and the Symfony coding standards, so let those dependencies manage the version rather than doing that yourself.
Ref: https://github.com/squizlabs/php_codesniffer/releases