Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Swift 4.2 migration #244

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Swift 4.2 migration #244

wants to merge 4 commits into from

Conversation

staguer
Copy link
Contributor

@staguer staguer commented Nov 1, 2018

Note: pod lib lint requires CocoaPods 1.6 for tvOS pod sanity test to pass

Sergei Taguer added 3 commits November 1, 2018 10:02
Note: `pod lib lint` requires CocoaPods 1.6 for tvOS pod sanity test to pass
@Nadohs
Copy link
Collaborator

Nadohs commented Jan 17, 2019

Are the tests passing locally? Travis is showing errors, but it seems more like its probably just not configured correctly for the 4.2 update.

This adds `-disable-concurrent-destination-testing`
flag to xcodebuild commands with multiple destinations
to disable concurrency issues happening on XCODE 10
target.

This also updates Apple TV target to `4k (at 1080)`
since normal 1080p version does not seem to have an
iOS 11.0 simulator target.
@Nadohs
Copy link
Collaborator

Nadohs commented Jan 19, 2019

Testing on my fork, this fixed the travis issues for me, except for the last step, which was pulling the latest version from cocoapods, which pulled version of code prior to your syntax updates in this PR... and so failed after 10 minutes because of that.

@ashihaby
Copy link

👍

@vasilenkoigor
Copy link

Hi! Any progress?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants