Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add component tokens #1615

Merged
merged 4 commits into from
Jul 24, 2024
Merged

chore: add component tokens #1615

merged 4 commits into from
Jul 24, 2024

Conversation

rssilva
Copy link
Contributor

@rssilva rssilva commented Jun 5, 2024

Description of the change

Add component tokens

Type of change

  • Non-Breaking Change (change to existing functionality)

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 818cbdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@localyze-pluto/design-tokens Minor
@localyze-pluto/theme Major
@localyze-pluto/components Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Size Change: 0 B

Total Size: 43 kB

ℹ️ View Unchanged
Filename Size
packages/components/dist/index.js 25.7 kB
packages/design-tokens/dist/index.js 8.91 kB
packages/design-tokens/dist/js/border-radius.js 181 B
packages/design-tokens/dist/js/border-style.js 140 B
packages/design-tokens/dist/js/border-width.js 146 B
packages/design-tokens/dist/js/colors.js 4.44 kB
packages/design-tokens/dist/js/font-family.js 140 B
packages/design-tokens/dist/js/font-size.js 261 B
packages/design-tokens/dist/js/font-weight.js 155 B
packages/design-tokens/dist/js/line-height.js 185 B
packages/design-tokens/dist/js/margin.js 131 B
packages/design-tokens/dist/js/padding.js 159 B
packages/design-tokens/dist/js/size.js 247 B
packages/design-tokens/dist/js/space.js 546 B
packages/design-tokens/dist/js/z-index.js 169 B
packages/theme/dist/index.js 1.47 kB

compressed-size-action

Base automatically changed from chore-replace-duplicated-tokens to main June 6, 2024 13:08
@rssilva rssilva force-pushed the chore-add-component-tokens branch from 30338b5 to 1fb629b Compare June 6, 2024 13:55
Copy link
Contributor

@apvale apvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Thanks, Rafa 💟

I ran the storybook and saw that the RGB values are broken in the colors list. Do you know why?

image

.changeset/great-flies-yawn.md Outdated Show resolved Hide resolved
@rssilva
Copy link
Contributor Author

rssilva commented Jun 6, 2024

@apvale good catch! I haven't noticed 🤦

This happens because the docs used to get the colors straight from the colors JSON directly and that was an hexadecimal value. Now it's a template variable.

https://github.com/Localitos/pluto/blob/main/packages/design-tokens/docs/components/constants.tsx#L48

I hope to have solved that with this

@rssilva rssilva force-pushed the chore-add-component-tokens branch from cd8f106 to 7840954 Compare June 17, 2024 11:51
@rssilva rssilva force-pushed the chore-add-component-tokens branch from 7840954 to 818cbdc Compare July 24, 2024 10:21
@rssilva rssilva merged commit 59de1bb into main Jul 24, 2024
14 checks passed
@rssilva rssilva deleted the chore-add-component-tokens branch July 24, 2024 10:34
@alpacatron alpacatron mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants