Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): allow box props to be added to Menu #1723

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

rssilva
Copy link
Contributor

@rssilva rssilva commented Sep 11, 2024

Description of the change

  • Allow BoxProps to be passed as properties to Menu component
  • Add property to change menu z index when opened

example:

<Box.div minHeight="100px">
  <Menu items={items} menuButton={menuButton} menuZIndex="10" />
  <Input type="text" />
</Box.div>

Screen Shot 2024-09-11 at 13 59 17

Type of change

  • Non-Breaking Change (change to existing functionality)

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 847f220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@localyze-pluto/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Size Change: +25 B (+0.06%)

Total Size: 43 kB

Filename Size Change
packages/components/dist/index.js 25.7 kB +25 B (+0.1%)
ℹ️ View Unchanged
Filename Size
packages/design-tokens/dist/index.js 8.91 kB
packages/design-tokens/dist/js/border-radius.js 181 B
packages/design-tokens/dist/js/border-style.js 139 B
packages/design-tokens/dist/js/border-width.js 145 B
packages/design-tokens/dist/js/colors.js 4.44 kB
packages/design-tokens/dist/js/font-family.js 140 B
packages/design-tokens/dist/js/font-size.js 260 B
packages/design-tokens/dist/js/font-weight.js 155 B
packages/design-tokens/dist/js/line-height.js 193 B
packages/design-tokens/dist/js/margin.js 131 B
packages/design-tokens/dist/js/padding.js 159 B
packages/design-tokens/dist/js/size.js 246 B
packages/design-tokens/dist/js/space.js 549 B
packages/design-tokens/dist/js/z-index.js 167 B
packages/theme/dist/index.js 1.47 kB

compressed-size-action

@rssilva rssilva merged commit 1792f22 into main Sep 11, 2024
17 checks passed
@rssilva rssilva deleted the chore-update-menu-accept-box-properties branch September 11, 2024 17:57
@alpacatron alpacatron mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants