Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the Heading default color #1731

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

apvale
Copy link
Contributor

@apvale apvale commented Sep 16, 2024

Description of the change

We realized the need to update all places where the Heading component is used to apply contentPrimary as the color. To simplify this, we'll set contentPrimary as the default color to avoid making changes in multiple places.

This was agreed with Hanna, but also let me know what you think about it.

Testing the change

  • Write your testing instructions here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Non-Breaking Change (change to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.

Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 464dcd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@localyze-pluto/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Size Change: +1 B (0%)

Total Size: 43 kB

Filename Size Change
packages/components/dist/index.js 25.7 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
packages/design-tokens/dist/index.js 8.91 kB
packages/design-tokens/dist/js/border-radius.js 181 B
packages/design-tokens/dist/js/border-style.js 140 B
packages/design-tokens/dist/js/border-width.js 145 B
packages/design-tokens/dist/js/colors.js 4.44 kB
packages/design-tokens/dist/js/font-family.js 140 B
packages/design-tokens/dist/js/font-size.js 260 B
packages/design-tokens/dist/js/font-weight.js 156 B
packages/design-tokens/dist/js/line-height.js 193 B
packages/design-tokens/dist/js/margin.js 131 B
packages/design-tokens/dist/js/padding.js 159 B
packages/design-tokens/dist/js/size.js 246 B
packages/design-tokens/dist/js/space.js 549 B
packages/design-tokens/dist/js/z-index.js 168 B
packages/theme/dist/index.js 1.47 kB

compressed-size-action

@apvale apvale merged commit 5e6410b into main Sep 17, 2024
17 checks passed
@apvale apvale deleted the feat/change-heading-default-color branch September 17, 2024 13:06
@alpacatron alpacatron mentioned this pull request Sep 17, 2024
franziiiini added a commit that referenced this pull request Sep 27, 2024
After updating the `Heading` default color ( in #1731), we realized that there are still headings using the prior color. With this change we should have address all headings and have the same color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants