fix(docs): change TOKEN_COLUMNS to avoid conflicting tokens with the same name #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rssilva
requested review from
apvale,
franziiiini,
MarynaLocalyze,
pecavalheiro,
sliminas and
kawtheressa
🦋 Changeset detectedLatest commit: 1c3d017 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rssilva
force-pushed
the
fix-avoid-docs-conflicting-tokens
branch
from
43f2746
to
8738fb2
Compare
|
Size Change: 0 B Total Size: 43 kB ℹ️ View Unchanged
|
apvale
approved these changes
Sep 18, 2024
| @@ -105,7 +107,7 @@ const FONT_SIZE = reduce( | |||
| name: "Name", | |||
| transform: getTokenNameFromTuple(prefix), | |||
| }, | |||
| { name: "Pixels", transform: getTokenComment }, | |||
| { name: "Weight", transform: getTokenValue }, | |||
There was a problem hiding this comment.
Shouldn't we use Weight only for font-weight?
There was a problem hiding this comment.
I'm removing this column since it doesn't make sense on font size!
| @@ -18,15 +18,17 @@ import { TokenName } from "./TokenName"; | |||
|
|
|||
| export const TokensTable = ({ | |||
| data, | |||
| name, | |||
There was a problem hiding this comment.
I noticed that we are using category in the type. What do you think of also using it here? Or maybe changing there to name so we have the same naming in both places?
There was a problem hiding this comment.
good call! I'm changing to category
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
colorBackgrounddecorative-strongcorrecting it tocolorBackgroundDecorativeStrongType of change
BEFORE
AFTER