Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): import named styled instead of default fixing warning #1771

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

rssilva
Copy link
Contributor

@rssilva rssilva commented Nov 8, 2024

Description of the change

Testing the change

  • Write your testing instructions here

Type of change

  • Non-Breaking Change (change to existing functionality)

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 5a3be97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Size Change: -6 B (-0.01%)

Total Size: 42.6 kB

Filename Size Change
packages/components/dist/index.js 25.9 kB -6 B (-0.02%)
ℹ️ View Unchanged
Filename Size
packages/design-tokens/dist/index.js 8.59 kB
packages/design-tokens/dist/js/border-radius.js 181 B
packages/design-tokens/dist/js/border-style.js 141 B
packages/design-tokens/dist/js/border-width.js 145 B
packages/design-tokens/dist/js/colors.js 4.44 kB
packages/design-tokens/dist/js/font-family.js 140 B
packages/design-tokens/dist/js/font-size.js 261 B
packages/design-tokens/dist/js/font-weight.js 157 B
packages/design-tokens/dist/js/line-height.js 193 B
packages/design-tokens/dist/js/margin.js 131 B
packages/design-tokens/dist/js/padding.js 159 B
packages/design-tokens/dist/js/size.js 247 B
packages/design-tokens/dist/js/space.js 343 B
packages/design-tokens/dist/js/z-index.js 168 B
packages/theme/dist/index.js 1.47 kB

compressed-size-action

@alpacatron
Copy link
Collaborator

Fails
🚫 You don't have a changeset file for your modifications.

Generated by 🚫 dangerJS against 5a3be97

Copy link
Contributor

@franziiiini franziiiini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changeset for this one as well?

@rssilva
Copy link
Contributor Author

rssilva commented Nov 8, 2024

Do we need a changeset for this one as well?

I would say that is not necessary since we don't need to publish this change to whoever is using it

@rssilva rssilva merged commit dbdcd14 into main Nov 11, 2024
16 of 17 checks passed
@rssilva rssilva deleted the fix-styled-import-warnings branch November 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants