Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCTO-576] implement design token storybook panel in pluto ds #988

Merged

Conversation

blumaa
Copy link
Contributor

@blumaa blumaa commented Aug 31, 2023

Description of the change

Here we are adding a preview of all of our design system tokens

Screenshot 2023-09-01 at 17 15 24
Screenshot 2023-09-01 at 17 14 51
Screenshot 2023-09-01 at 17 15 31
Screenshot 2023-09-01 at 17 15 37
Screenshot 2023-09-01 at 17 15 49
Screenshot 2023-09-01 at 17 15 58

Testing the change

  • Write your testing instructions here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Non-Breaking Change (change to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.

@blumaa blumaa requested a review from a team as a code owner August 31, 2023 15:52
@blumaa blumaa self-assigned this Aug 31, 2023
@blumaa blumaa requested a review from a team as a code owner August 31, 2023 15:52
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

⚠️ No Changeset found

Latest commit: 776dc60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@blumaa blumaa requested review from rssilva and apvale August 31, 2023 15:52
@blumaa blumaa closed this Sep 1, 2023
@blumaa blumaa reopened this Sep 1, 2023
@blumaa blumaa force-pushed the octo-576-implement-design-token-storybook-panel-in-pluto-ds branch 2 times, most recently from fd21bcb to 4e55462 Compare September 1, 2023 08:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Size Change: 0 B

Total Size: 29.9 kB

ℹ️ View Unchanged
Filename Size
packages/components/dist/index.js 23 kB
packages/design-tokens/dist/index.js 2.62 kB
packages/design-tokens/dist/js/border-radius.js 180 B
packages/design-tokens/dist/js/border-style.js 141 B
packages/design-tokens/dist/js/border-width.js 146 B
packages/design-tokens/dist/js/colors.js 867 B
packages/design-tokens/dist/js/font-family.js 145 B
packages/design-tokens/dist/js/font-size.js 198 B
packages/design-tokens/dist/js/font-weight.js 158 B
packages/design-tokens/dist/js/line-height.js 204 B
packages/design-tokens/dist/js/size.js 247 B
packages/design-tokens/dist/js/space.js 425 B
packages/design-tokens/dist/js/z-index.js 169 B
packages/theme/dist/index.js 1.43 kB

compressed-size-action

@blumaa blumaa force-pushed the octo-576-implement-design-token-storybook-panel-in-pluto-ds branch from 4e55462 to c1081a3 Compare September 1, 2023 08:57
nyan07

This comment was marked as outdated.

nyan07

This comment was marked as outdated.

nyan07

This comment was marked as outdated.

@nyan07

This comment was marked as resolved.

@blumaa

This comment was marked as resolved.

Copy link
Contributor

@sliminas sliminas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot! 🎉

Copy link
Contributor

@nyan07 nyan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 🚀

@blumaa blumaa merged commit 512ac22 into main Sep 15, 2023
10 checks passed
@blumaa blumaa deleted the octo-576-implement-design-token-storybook-panel-in-pluto-ds branch September 15, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants