Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFFI-30: Add read-only editor type for TextField #164

Merged
merged 2 commits into from
Apr 26, 2024
Merged

OFFI-30: Add read-only editor type for TextField #164

merged 2 commits into from
Apr 26, 2024

Conversation

sarahelsaig
Copy link
Member

@sarahelsaig sarahelsaig commented Apr 23, 2024 •
edited by jira bot
Loading

@wAsnk
Copy link
Member

wAsnk commented Apr 24, 2024

You are missing the OSOCE PR for this.

@sarahelsaig
Copy link
Member Author

sarahelsaig commented Apr 24, 2024 •
edited
Loading

You are missing the OSOCE PR for this.

I didn't expect that you'd already merge the previous OSOCE PR for OFFI-30. As I recall we aren't supposed to merge submodules until the whole issue is ready.

EDIT: on second look, the OSOCE PR was already pointing to this branch, so now OSOCE dev points there too. This means I can't open a new PR either.

@wAsnk wAsnk merged commit 3a5b67a into dev Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wAsnk wAsnk wAsnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahelsaig @wAsnk