Translation PR. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also think that first %s in not necessary in "my-totem-doll.modmenu.old_config_library_screen.message" and without it the Message can look like this: "Your [YACL] version is outdated for My Totem Doll Configuration. Please update §6§lYACL§f to version %s or higher.\n\n§a§lOpen §6§lYACL §a§lModrinth page?"
I also think that first %s in not necessary in "my-totem-doll.modmenu.old_config_library_screen.message" and without it the Message can look like this: "Your [YACL] version is outdated for My Totem Doll Configuration. Please update §6§lYACL§f to version %s or higher.\n\n§a§lOpen §6§lYACL §a§lModrinth page?"
|
Salam! About construction "%s with version %s", yes, you're right, maybe the phrase About first unnecessary %s, I wrote it to make it easier to compare two versions, also it helps to know which library version was detected by mod. Everything looks great, thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selam!
Firstly, there's Vanilla-ish Tatar Translation!
Secondly, I made one small fix for English. Also I suggest to remove first %s due to being not necessary in "my-totem-doll.modmenu.old_config_library_screen.message". And without it the Message can look like this: "Your [YACL] version is outdated for My Totem Doll Configuration. Please update §6§lYACL§f to version %s or higher.\n\n§a§lOpen §6§lYACL §a§lModrinth page?". In My Honest Opinion this Message sounds more correct and better because I didn't see and didn't hear any English Translations with construction "%s with version %s".
P. S. That Fix displays twice (probably because I missed with branches), but I did that only once =)