fix: frontend tests

MAIF · Sep 15, 2024 · e0be246 · e0be246
1 parent 9545475
commit e0be246
Show file tree

Hide file tree

Showing 7 changed files with 44 additions and 30 deletions.
diff --git a/izanami-frontend/package-lock.json b/izanami-frontend/package-lock.json
diff --git a/izanami-frontend/package.json b/izanami-frontend/package.json
@@ -36,7 +36,7 @@
     "uuid": "^8.3.2"
   },
   "devDependencies": {
-    "@playwright/test": "^1.41.1",
+    "@playwright/test": "^1.47.1",
     "@types/node": "^20.12.11",
     "@types/react-dom": "^18.3.0",
     "@types/swagger-ui": "^3.52.4",

diff --git a/izanami-frontend/playwright.config.ts b/izanami-frontend/playwright.config.ts
@@ -13,6 +13,8 @@ export const STORAGE_STATE = path.join(__dirname, "playwright/.auth/user.json");
  * See https://playwright.dev/docs/test-configuration.
  */
 export default defineConfig({
+  timeout: 120_000,
+  expect: { timeout: 10_000 },
   testDir: "./tests",
   /* Run tests in files in parallel */
   fullyParallel: true,
@@ -45,6 +47,7 @@ export default defineConfig({
       name: "chromium",
       dependencies: ["setup"],
       use: { ...devices["Desktop Chrome"], storageState: STORAGE_STATE },
+      fullyParallel: true,
     },
 
     /*{

diff --git a/izanami-frontend/src/components/GenericTable.tsx b/izanami-frontend/src/components/GenericTable.tsx
@@ -178,7 +178,7 @@ export function GenericTable<T extends RowData>(props: TProps<T>) {
                 aria-expanded="false"
                 aria-label="actions"
               >
-                <i className="bi bi-three-dots-vertical" aria-label="actions"></i>
+                <i className="bi bi-three-dots-vertical"></i>
               </button>
               <ul className="dropdown-menu">{actionList}</ul>
             </div>
@@ -287,11 +287,23 @@ export function GenericTable<T extends RowData>(props: TProps<T>) {
                 let sortIcon = <></>;
                 const sorted = header.column.getIsSorted();
                 if (sorted === "desc") {
-                  sortIcon = <i className="bi bi-arrow-down ms-2" aria-label="move down"></i>;
+                  sortIcon = (
+                    <i
+                      className="bi bi-arrow-down ms-2"
+                      aria-label="move down"
+                    ></i>
+                  );
                 } else if (sorted === "asc") {
-                  sortIcon = <i className="bi bi-arrow-up ms-2" aria-label="move up"></i>;
+                  sortIcon = (
+                    <i className="bi bi-arrow-up ms-2" aria-label="move up"></i>
+                  );
                 } else if (header.column.getCanSort()) {
-                  sortIcon = <i className="bi bi-arrow-down-up ms-2" aria-label="move"></i>;
+                  sortIcon = (
+                    <i
+                      className="bi bi-arrow-down-up ms-2"
+                      aria-label="move"
+                    ></i>
+                  );
                 }
                 return (
                   <th

diff --git a/izanami-frontend/tests/features.spec.ts b/izanami-frontend/tests/features.spec.ts
@@ -13,10 +13,10 @@ test.use({
 
 async function featureAction(page: Page, name: string) {
   await page.getByLabel("actions").click();
-  if ((await page.getByRole("link", { name: name }).count()) === 0) {
+  /*if ((await page.getByRole("link", { name: name }).count()) === 0) {
     await page.getByLabel("actions").click();
-  }
-  await page.getByRole("link", { name: name }).click();
+  }*/
+  await page.getByRole("link", { name: name }).click({ force: true });
 }
 
 test.describe("Project screen should", () => {

diff --git a/izanami-frontend/tests/tenants.spec.ts b/izanami-frontend/tests/tenants.spec.ts
@@ -6,10 +6,7 @@ test.use({
 });
 
 async function createTenant(page: Page, tenant: string) {
-  Promise.race([
-    page.getByRole("button", { name: "create a new tenant" }).click(),
-    page.getByRole("button", { name: "Create new tenant" }).click(),
-  ]);
+  await page.getByRole("button", { name: "Create new tenant" }).click();
 
   await page.getByLabel("Tenant name").fill(tenant);
   await page.getByRole("button", { name: "Save" }).click();

diff --git a/izanami-frontend/tests/webhooks.spec.ts b/izanami-frontend/tests/webhooks.spec.ts
@@ -14,12 +14,14 @@ test.use({
 
 async function webhookAction(page: Page, name: string) {
   await page.getByLabel("actions").click();
-  if (
+  /*if (
     (await page.getByRole("link", { name: name, exact: true }).count()) === 0
   ) {
     await page.getByLabel("actions").click();
-  }
-  await page.getByRole("link", { name: name, exact: true }).click();
+  }*/
+  await page
+    .getByRole("link", { name: name, exact: true })
+    .click({ force: true });
 }
 
 test.describe("Webhook screen should", () => {