Fix/missing zero balance check

[mantricjavier]

Description and Motivation

Fixes #23 by verifying balances are checked before sending them with BankMsg::Send.

Note: It's worth noting the order of the coins does not affect the result when sending coins via cosmwasm. See https://github.com/mantricjavier/coins-order-cosmwasm-test for reference.

Related Issues

---

Checklist:

• I have read MANTRA's contribution guidelines.
• My pull request has a sound title and description (not something vague like Update index.md)
• All existing and new tests are passing.
• I updated/added relevant documentation.
• The code is formatted properly cargo fmt --all --.
• Clippy doesn't report any issues cargo clippy -- -D warnings.
• I have regenerated the schemas if needed with just schemas.

Summary by CodeRabbit

• New Features

  • Enhanced liquidity management with checks for empty deposits and asset validation.
  • Improved deployment scripts for the MANTRA Dex contracts, including better error handling and user input.

• Bug Fixes

  • Conditional checks added to prevent unnecessary transactions related to farm creation fees and penalty fees during withdrawals.

• Tests

  • Expanded integration tests for the farm-manager module to cover more scenarios and improve error handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes encompass several modifications across various files in the farm-manager and pool-manager contracts, as well as deployment scripts. Key adjustments include conditional checks in fee-related functions to prevent unnecessary transactions, updates to liquidity management functions for better validation, and enhancements to integration tests. Additionally, deployment scripts have been modified to improve gas price settings and deployment functionalities. Overall, these changes aim to refine the control flow and enhance the robustness of the system.

Changes

File Path	Change Summary
contracts/farm-manager/src/helpers.rs	Added conditional check in process_farm_creation_fee to send fee only if greater than zero.
contracts/farm-manager/src/manager/commands.rs	Modified close_farms to push bank message only if farm_asset.amount is greater than zero.
contracts/farm-manager/src/position/commands.rs	Added conditional check in withdraw_position to send penalty fee only if greater than zero.
contracts/farm-manager/tests/integration.rs	Added and modified several integration tests, enhancing error handling and logic for managing farms and positions. New test cases include various scenarios related to farm and position management.
contracts/pool-manager/src/liquidity/commands.rs	Updated provide_liquidity and withdraw_liquidity functions to include checks for empty deposits and filter out zero amounts from refund assets.
scripts/deployment/deploy_env/base_env.sh	Updated TXFLAG variable to change gas price from 0.35$DENOM to 2$DENOM.
scripts/deployment/deploy_mantra_dex.sh	Enhanced deployment scripts with updates to store_artifact_on_chain, added store_artifacts_on_chain, and refined init_* functions for better error handling and user input.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FarmManager
    participant FeeCollector

    User->>FarmManager: Create Farm
    FarmManager->>FeeCollector: Check fee amount
    alt Fee > 0
        FarmManager->>FeeCollector: Send fee
    end

Loading

🐰 "In the fields where the rabbits play,
A new fee check has come to stay.
With farms and liquidity, all in line,
Our code is better, oh so fine!
Let’s hop along, with joy we cheer,
For smoother paths, the change is here!" 🥕

---

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.