chore(pool_manager): validate amount of assets when creating a pool

[mantricjavier]

Description and Motivation

Fixes #51 by validating the asset_denoms and asset_decimal vectors to have less than or equal to MAX_ASSETS_PER_POOL assets.

Related Issues

---

Checklist:

• I have read MANTRA's contribution guidelines.
• My pull request has a sound title and description (not something vague like Update index.md)
• All existing and new tests are passing.
• I updated/added relevant documentation.
• The code is formatted properly cargo fmt --all --.
• Clippy doesn't report any issues cargo clippy -- -D warnings.
• I have regenerated the schemas if needed with just schemas.

Summary by CodeRabbit

• New Features

  • Enhanced pool creation with new validation for asset denominations and decimals.
  • Added error handling for attempts to create pools exceeding asset limits.

• Bug Fixes

  • Improved error handling in tests for liquidity provision and pool creation scenarios.

• Tests

  • Introduced new test cases to verify pool creation limits and liquidity handling.
  • Expanded existing tests to ensure accurate fee calculations and error reporting.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces enhancements to the create_pool function in the pool manager's command module, adding a validation step to ensure asset denominations and decimals align, while also enforcing a maximum asset limit per pool. Additionally, the integration tests have been significantly improved with new test cases focusing on error handling and liquidity provision, ensuring that pools are created correctly and that fees are accurately managed.

Changes

File Path	Change Summary
contracts/pool-manager/src/manager/commands.rs	Enhanced create_pool function with validation for asset denominations and maximum assets; updated error handling.
contracts/pool-manager/src/tests/integration_tests.rs	Added new test cant_create_pool_with_large_number_of_assets; improved error handling and fee verification in liquidity tests; adjusted pool creation logic.

Poem

In the garden where pools do grow,
A rabbit hops, with a gleeful glow.
With checks in place, no assets amiss,
Creating pools is now pure bliss!
Hooray for tests, both strong and bright,
Ensuring our pools are just right! 🐇✨

---

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Schema generation had missing jobs:

contracts/pool-manager/schema/pool-manager.json

Please run just schemas locally and upload the generated schemas.