chore: cleanup development leftovers

[mantricjavier]

Description and Motivation

Fixes #59 , removing todos and unused code.

Related Issues

---

Checklist:

• I have read MANTRA's contribution guidelines.
• My pull request has a sound title and description (not something vague like Update index.md)
• All existing and new tests are passing.
• I updated/added relevant documentation.
• The code is formatted properly cargo fmt --all --.
• Clippy doesn't report any issues cargo clippy -- -D warnings.
• I have regenerated the schemas if needed with just schemas.

Summary by CodeRabbit

• New Features

  • Enhanced position management functionalities, including improved checks for creating, expanding, closing, and withdrawing positions.
  • Updated fee computation methods to ensure better error handling and accuracy.

• Bug Fixes

  • Improved error handling across various functions to prevent failures and ensure robust operations.

• Refactor

  • Removed unnecessary structures related to stable swap parameters, simplifying pool management logic.

• Documentation

  • Enhanced comments for clarity and understanding throughout the codebase.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve multiple files related to position management and fee computation within a decentralized finance (DeFi) context. Enhancements include improved error handling, additional validations, and structural modifications aimed at streamlining code and enhancing functionality. Key updates involve the removal of redundant structures, adjustments to method signatures for better error propagation, and the introduction of new checks to ensure data integrity and reliability in operations.

Changes

File Path	Change Summary
contracts/farm-manager/src/position/commands.rs	Enhanced position management functions with new validations and error handling improvements.
contracts/pool-manager/src/helpers.rs	Improved error handling in fee computations and updated comments for clarity.
contracts/pool-manager/src/queries.rs	Enhanced error handling in query_reverse_simulation and improved code clarity.
contracts/pool-manager/src/state.rs	Removed StableSwapParams struct and associated constant to simplify pool management logic.
packages/amm/src/fee.rs	Updated fee structures to include error handling and safe arithmetic operations in fee computations.
packages/amm/src/pool_manager.rs	Removed StableSwapParams struct and related comments to streamline pool management code.

Poem

In the fields of code we play,
Enhancements bloom, bright as day.
With checks and balances, we refine,
A DeFi dance, so divine!
Errors handled, clarity found,
In this rabbit's world, joy abounds! 🐇✨

---

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Schema generation had missing jobs:

contracts/pool-manager/schema/pool-manager.json

Please run just schemas locally and upload the generated schemas.