Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test large numbers on dex #87

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

mantricjavier
Copy link
Collaborator

@mantricjavier mantricjavier commented Nov 4, 2024

Description and Motivation

Add tests with large numbers on the dex.

Related Issues


Checklist:

  • I have read MANTRA's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed with just schemas.

Summary by CodeRabbit

  • Tests
    • Introduced new test cases for handling large digit swaps in liquidity pools.
    • Enhanced existing tests to verify liquidity provision with single assets and edge cases.
    • Updated the testing suite to accommodate an additional sender for improved testing scenarios.

Copy link

coderabbitai bot commented Nov 4, 2024

Walkthrough

The changes include the addition of new test cases in the integration_tests.rs file to handle large digit swaps in both constant product and stable swap pools, enhancing the robustness of liquidity provision and swap operations. Additionally, the TestingSuite struct in suite.rs has been modified to increase the senders field from three to four addresses, ensuring that the testing suite accommodates an additional sender.

Changes

File Path Change Summary
contracts/pool-manager/src/tests/integration_tests.rs Added tests: swap_large_digits_xyk, swap_large_digits_stable, swap_large_digits_stable_18_digits for large digit swaps and liquidity provision. Enhanced existing tests for single asset liquidity provision and fee calculations.
contracts/pool-manager/src/tests/suite.rs Updated TestingSuite struct: changed senders from an array of three Addr elements to four, including a new sender in the default_with_balances method.

Poem

🐰 In the realm of swaps and pools so bright,
New tests are added, what a delight!
With digits so large, they dance and play,
Ensuring our liquidity won't sway.
Four senders now join the testing spree,
Hopping along, as happy as can be! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6250844 and e68418c.

📒 Files selected for processing (2)
  • contracts/pool-manager/src/tests/integration_tests.rs (1 hunks)
  • contracts/pool-manager/src/tests/suite.rs (3 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mantricjavier mantricjavier merged commit e662dff into main Nov 4, 2024
4 of 5 checks passed
@mantricjavier mantricjavier deleted the chore/test-large-numbers branch November 4, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant