Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libmdanalysis to lib #3913

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

hmacdope
Copy link
Member

@hmacdope hmacdope commented Nov 9, 2022

Fixes #3912

Changes made in this Pull Request:

  • Moves the libmdanalysis init.pxd file to lib.

PR Checklist

  • CHANGELOG updated?
  • Issue raised/referenced?

@hmacdope hmacdope added the CZI-performance performance track of CZIEOSS4 grant label Nov 9, 2022
@hmacdope hmacdope self-assigned this Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 94.35% // Head: 94.35% // No change to project coverage 👍

Coverage data is based on head (e9d9b65) compared to base (345d5d2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3913   +/-   ##
========================================
  Coverage    94.35%   94.35%           
========================================
  Files          194      194           
  Lines        25060    25060           
  Branches      3392     3392           
========================================
  Hits         23645    23645           
  Misses        1366     1366           
  Partials        49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hmacdope hmacdope marked this pull request as ready for review November 9, 2022 09:35
@IAlibay
Copy link
Member

IAlibay commented Nov 9, 2022

Since this made it to 2.3.0, do we think the userbase was large enough that we need to semver or are we happy going ahead with the change?

Also were there any docs associated with this?

@hmacdope
Copy link
Member Author

hmacdope commented Nov 9, 2022

I don't think there is a need to semver, but there should be docs in the developer docs. Ill add them.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to put this down as a "approved", but we should get those docs in somewhere.

@IAlibay IAlibay added this to the 2.4.0 milestone Nov 11, 2022
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hmacdope
Copy link
Member Author

Cheers, new issue raised #3921

@IAlibay IAlibay merged commit 6444031 into MDAnalysis:develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-lib CZI-performance performance track of CZIEOSS4 grant maintainability
Projects
Development

Successfully merging this pull request may close these issues.

Move libmdanalysis to lib
3 participants