-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move libmdanalysis to lib #3913
Conversation
Codecov ReportBase: 94.35% // Head: 94.35% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #3913 +/- ##
========================================
Coverage 94.35% 94.35%
========================================
Files 194 194
Lines 25060 25060
Branches 3392 3392
========================================
Hits 23645 23645
Misses 1366 1366
Partials 49 49 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Since this made it to 2.3.0, do we think the userbase was large enough that we need to semver or are we happy going ahead with the change? Also were there any docs associated with this? |
I don't think there is a need to semver, but there should be docs in the developer docs. Ill add them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to put this down as a "approved", but we should get those docs in somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Cheers, new issue raised #3921 |
Fixes #3912
Changes made in this Pull Request:
libmdanalysis
init.pxd file to lib.PR Checklist