Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron trigger to cirrus.star #4217

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add cron trigger to cirrus.star #4217

merged 1 commit into from
Jul 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 30, 2023

Towards #4216

Changes made in this Pull Request:

  • Just add an extra CRON trigger to the cirrus star. I made the necessary changes on the provider.
  • If it works, once end of August comes we just remove the PR trigger and we're done.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://mdanalysis--4217.org.readthedocs.build/en/4217/

@github-actions
Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ac30c88) 93.62% compared to head (37ca0ce) 93.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4217   +/-   ##
========================================
  Coverage    93.62%   93.62%           
========================================
  Files          193      193           
  Lines        25294    25295    +1     
  Branches      4063     4063           
========================================
+ Hits         23682    23683    +1     
  Misses        1096     1096           
  Partials       516      516           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 30, 2023

This won't do anything until it's merged, the fact that both current Cirrus jobs are running is all the check we needed. If someone can review that'd be great, otherwise I'll review tomorrow so that I can check that Tuesday's Cron trigger is working as intended.

@IAlibay
Copy link
Member Author

IAlibay commented Jul 31, 2023

Self-merging to make sure we actually get to test the cron trigger this evening.

@IAlibay IAlibay merged commit 938607c into develop Jul 31, 2023
23 of 26 checks passed
@IAlibay IAlibay deleted the cirrus-cron branch July 31, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant