Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Py3.12 for Azure pipelines CI #4327

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add Py3.12 for Azure pipelines CI #4327

merged 2 commits into from
Oct 30, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023

Probably going to fail, but let's at least try.

Changes made in this Pull Request:

  • Bump up max Azure pipelines CI tests to py3.12 (from 3.11)

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4327.org.readthedocs.build/en/4327/

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

This will take some time to fix everything - current hold up is pytng's upcoming py3.12 release.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03a9550) 93.37% compared to head (9c96431) 93.37%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4327     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22295    23403   +1108     
  Branches      4075     4075             
==========================================
+ Hits         20818    21853   +1035     
- Misses         962     1035     +73     
  Partials       515      515             

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IAlibay IAlibay changed the title Try out Py3.12 for Azure pipelines CI Add Py3.12 for Azure pipelines CI Oct 28, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

Seems good to go.

Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I spot checked the log output in one of the new 3.12 jobs, and we still have 3.11 tested elsewhere in our overall matrix, so in it goes.

@tylerjereddy tylerjereddy merged commit 170c514 into develop Oct 30, 2023
23 checks passed
@tylerjereddy tylerjereddy deleted the py312-azure branch October 30, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants