-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose C distance backend in libmdanalysis.pxd #4342
Conversation
Linter Bot Results:Hi @hmacdope! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4342 +/- ##
===========================================
- Coverage 93.37% 93.36% -0.01%
===========================================
Files 170 184 +14
Lines 22295 23433 +1138
Branches 4075 4079 +4
===========================================
+ Hits 20818 21879 +1061
- Misses 962 1036 +74
- Partials 515 518 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hmacdope.
Only question here is docs - do we have an rst stub or anything where we can document these things? It feels like a loss to have this all be exposed internally but without any information that it exists.
@IAlibay good point i'll add a docs page |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@IAlibay turns out we do have a short bit of docs that covers this |
Thanks for checking, anything that needs updating there for this change? |
Ah sorry I'm blind, fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
Fixes #4315
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4342.org.readthedocs.build/en/4342/