Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3.12 to cron runners #4443

Merged
merged 1 commit into from
Jan 30, 2024
Merged

add 3.12 to cron runners #4443

merged 1 commit into from
Jan 30, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 30, 2024

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4443.org.readthedocs.build/en/4443/

@IAlibay IAlibay marked this pull request as ready for review January 30, 2024 21:11
Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a992d7) 93.37% compared to head (e2e753b) 93.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4443     +/-   ##
==========================================
  Coverage    93.37%   93.38%             
==========================================
  Files          171      185     +14     
  Lines        21737    22851   +1114     
  Branches      4012     4012             
==========================================
+ Hits         20298    21339   +1041     
- Misses         952     1025     +73     
  Partials       487      487             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @IAlibay

@RMeli RMeli merged commit 6ba7682 into develop Jan 30, 2024
23 of 26 checks passed
@RMeli RMeli deleted the 312-cron branch January 30, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants