-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mutable data from progressbar_kwargs
argument in AnalysisBase.run()
#4459
Conversation
Hello @PicoCentauri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-17 10:20:15 UTC |
0a125f7
to
cfe9b6a
Compare
Linter Bot Results:Hi @PicoCentauri! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
cfe9b6a
to
7c9be22
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4459 +/- ##
===========================================
- Coverage 93.69% 93.67% -0.03%
===========================================
Files 168 180 +12
Lines 21211 22292 +1081
Branches 3911 3912 +1
===========================================
+ Hits 19873 20881 +1008
- Misses 886 959 +73
Partials 452 452 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
I'll give it a bit of time before merge in case anyone feels like this is API breaking, but I 100% support None over empty dictionary.
Thanks @IAlibay ! There is no rush with this. |
Also I removed some trailing spaces and added a fixture for a universe in the
test_base
to clean them up a bit.PR Checklist
[ ] Docs?[ ] Issue raised/referenced?Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4459.org.readthedocs.build/en/4459/