Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutable data from progressbar_kwargs argument in AnalysisBase.run() #4459

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

PicoCentauri
Copy link
Contributor

@PicoCentauri PicoCentauri commented Feb 17, 2024

Also I removed some trailing spaces and added a fixture for a universe in the test_base to clean them up a bit.

PR Checklist

  • Tests?
  • [ ] Docs?
  • CHANGELOG updated?
  • [ ] Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4459.org.readthedocs.build/en/4459/

@pep8speaks
Copy link

pep8speaks commented Feb 17, 2024

Hello @PicoCentauri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-02-17 10:20:15 UTC

Copy link

github-actions bot commented Feb 17, 2024

Linter Bot Results:

Hi @PicoCentauri! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/8166100470/job/22324308697


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (d366921) to head (6a68dfb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4459      +/-   ##
===========================================
- Coverage    93.69%   93.67%   -0.03%     
===========================================
  Files          168      180      +12     
  Lines        21211    22292    +1081     
  Branches      3911     3912       +1     
===========================================
+ Hits         19873    20881    +1008     
- Misses         886      959      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

I'll give it a bit of time before merge in case anyone feels like this is API breaking, but I 100% support None over empty dictionary.

@PicoCentauri
Copy link
Contributor Author

Thanks @IAlibay ! There is no rush with this.

@IAlibay IAlibay merged commit 8df5115 into MDAnalysis:develop Mar 10, 2024
23 of 24 checks passed
@PicoCentauri PicoCentauri deleted the universe-fixture branch June 5, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants