-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PEP518] Improve testsuite packaging #4463
Conversation
Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-23 07:10:18 UTC |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4463 +/- ##
===========================================
- Coverage 93.38% 93.37% -0.01%
===========================================
Files 171 183 +12
Lines 21744 22822 +1078
Branches 4014 4014
===========================================
+ Hits 20305 21310 +1005
- Misses 952 1025 +73
Partials 487 487 ☔ View full report in Codecov by Sentry. |
Thanks for the review @RMeli - I think I've addressed most comments, the social media stuff might need more discussion. I'm of the opinion that the pyproject.toml url links barely get used so we could probably just not think about them too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Irfan, LGTM
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4463.org.readthedocs.build/en/4463/