-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise Python version to 3.10 #4503
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4503 +/- ##
===========================================
- Coverage 93.69% 93.63% -0.06%
===========================================
Files 168 180 +12
Lines 21211 22294 +1083
Branches 3911 3908 -3
===========================================
+ Hits 19873 20875 +1002
- Misses 886 961 +75
- Partials 452 458 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a bump in the darkerbot
action is missing? Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @RMeli - just not fully sure what you meant 😅
@@ -33,7 +33,7 @@ jobs: | |||
|
|||
- uses: actions/setup-python@v4 | |||
with: | |||
python-version: 3.9 | |||
python-version: "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RMeli sorry I don't fully understand if you mean this or the actual darker action version number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks! Totally forgot that was even a thing 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Thanks @IAlibay. I think the |
Yeah it's been popping up all over the place (i.e. unrelated to MDA). |
Whether or not we follow SPEC0 or NEP29, Python 3.9 is getting dropped in early April. Since there's nearly no chance we would release until then, we might as well go ahead and bump Python up.
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4503.org.readthedocs.build/en/4503/