Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Python version to 3.10 #4503

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Raise Python version to 3.10 #4503

merged 2 commits into from
Mar 11, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 10, 2024

Whether or not we follow SPEC0 or NEP29, Python 3.9 is getting dropped in early April. Since there's nearly no chance we would release until then, we might as well go ahead and bump Python up.

Changes made in this Pull Request:

  • Minimum supported Python version is not 3.10

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4503.org.readthedocs.build/en/4503/

@IAlibay IAlibay marked this pull request as ready for review March 10, 2024 14:48
Copy link

github-actions bot commented Mar 10, 2024

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (d366921) to head (fe15f6c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4503      +/-   ##
===========================================
- Coverage    93.69%   93.63%   -0.06%     
===========================================
  Files          168      180      +12     
  Lines        21211    22294    +1083     
  Branches      3911     3908       -3     
===========================================
+ Hits         19873    20875    +1002     
- Misses         886      961      +75     
- Partials       452      458       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay requested a review from RMeli March 10, 2024 20:18
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bump in the darkerbot action is missing? Otherwise LGTM.

Copy link
Member Author

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @RMeli - just not fully sure what you meant 😅

@@ -33,7 +33,7 @@ jobs:

- uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: "3.10"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RMeli sorry I don't fully understand if you mean this or the actual darker action version number

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks! Totally forgot that was even a thing 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@RMeli
Copy link
Member

RMeli commented Mar 11, 2024

Thanks @IAlibay. I think the mypy issue comes from upstream? I feel we can just discard it for now...

@IAlibay
Copy link
Member Author

IAlibay commented Mar 11, 2024

Thanks @IAlibay. I think the mypy issue comes from upstream? I feel we can just discard it for now...

Yeah it's been popping up all over the place (i.e. unrelated to MDA).

@RMeli RMeli merged commit 0582265 into develop Mar 11, 2024
21 of 23 checks passed
@RMeli RMeli deleted the py3.10-bump branch March 11, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants