-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Parallelization to analysis.bat #4693
Conversation
Added clients
added bat to conftest.py
Added parallelization to bat
adjusted
Updated Changelog
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-09-09 19:35:14 UTC |
Linter Bot Results:Hi @talagayev! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4693 +/- ##
========================================
Coverage 93.87% 93.87%
========================================
Files 173 173
Lines 21428 21434 +6
Branches 3980 3981 +1
========================================
+ Hits 20116 20122 +6
Misses 858 858
Partials 454 454 ☔ View full report in Codecov by Sentry. |
movement to lines
trying to fix class static error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @talagayev!
Perfect :) |
Just need to fix conflicts. |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a versionchanged, can copy from gnm. Thanks.
Addition of versionchanged
Added the versionchanged in the BAT class, will resolve now the conflicts :) |
@orbeckst can you re-review here? |
Thanks @talagayev ! |
Happy to help :) |
* Fixes MDAnalysis#4663 * Changes made in this Pull Request: - parallelization of the class BAT in analysis.bat.py - addition of parallelization tests (including fixtures in analysis/conftest.py) - update docs for analysis class - update of CHANGELOG
Fixes #4663
Changes made in this Pull Request:
BAT
inanalysis.bat.py
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4693.org.readthedocs.build/en/4693/